🚀 go-pugleaf

Mam ostatnie pytanie dotyczace MVC. Gdzie mam umieszczać obsługę błędów operacji bazodanowych? Aktualnie mam bibliotekę Common:

class Common {
private $ci;
public function __construct() {
    $this->ci =& get_instance();
}
public function error($msg) {
    $this->ci->mylog->logError($msg);
    show_error($msg);
}
...
}

Błędy obsługuję tak: kontroler zawiera:

public function modify_agency() {
    $agencyId = intval($this->input->post('agency_id'));
    $this->load->model('Agencies_model');
    if (!$this->Agencies_model->modifyAgency($agencyId, 
                                             trim($this->input->post('name')),
                                             trim($this->input->post('email')),
                                             trim($this->input->post('www')),
                                             trim($this->input->post('mobile1')),
                                             trim($this->input->post('mobile2')),
                                             trim($this->input->post('phone1')),
                                             trim($this->input->post('phone2')),
                                             trim($this->input->post('contact_person')),
                                             trim($this->input->post('town')),
                                             trim($this->input->post('remarks')))) {
        $this->common->error(ERRMSG_DATABASE_OPERATION_FAILED);
    }
    redirect('/admin/report/agencies');
}

natomiast model zawiera:

public function modifyAgency($agencyId, $name, $email, $www, $mobile1, $mobile2, $phone1, $phone2, $contactPerson, $town, $remarks) {
    $ok = TRUE;
    if (preg_match('/' . EMAIL_REGEXP . '/i', $email, $matches) > 0) {
        $email = $matches[0];
    } else {
        $ok = FALSE;
    }
    $ok = ($ok && (is_empty($mobile1) || $this->ci->common->isValidMobile($mobile1)));
    $ok = ($ok && (is_empty($mobile2) || $this->ci->common->isValidMobile($mobile2)));
    $ok = ($ok && (is_empty($phone1) || $this->ci->common->isValidPhone($phone1)));
    $ok = ($ok && (is_empty($phone2) || $this->ci->common->isValidPhone($phone2)));
    if (!$ok) {
        $this->ci->common->error(ERRMSG_INVALID_AGENCY_DATA);
    }
    $www = (is_empty($www) ? NULL : $www);
    $mobile1 = (is_empty($mobile1) ? NULL : $mobile1);
    $mobile2 = (is_empty($mobile2) ? NULL : $mobile2);
    $phone1 = (is_empty($phone1) ? NULL : $phone1);
    $phone2 = (is_empty($phone2) ? NULL : $phone2);
    $contactPerson = (is_empty($contactPerson) ? NULL : $contactPerson);
    $town = (is_empty($town) ? NULL : $town);
    $remarks = (is_empty($remarks) ? NULL : $remarks);
    $sql = 'UPDATE agencies SET ' .
           'name = ' . $this->ci->common->convertToDb($name) . ', ' .
           'email = ' . $this->ci->common->convertToDb($email) . ', ' .
           'www = ' . $this->ci->common->convertToDb($www) . ', ' .
           'mobile1 = ' . $this->ci->common->convertToDb($mobile1) . ', ' .
           'mobile2 = ' . $this->ci->common->convertToDb($mobile2) . ', ' . 
           'phone1 = ' . $this->ci->common->convertToDb($phone1) . ', ' .
           'phone2 = ' . $this->ci->common->convertToDb($phone2) . ', ' . 
           'contact_person = ' . $this->ci->common->convertToDb($contactPerson) . ', ' . 
           'town = ' . $this->ci->common->convertToDb($town) . ', ' .
           'remarks = ' . $this->ci->common->convertToDb($remarks) .            
           " WHERE agency_id = $agencyId";
    $this->db->query($sql);
    return $this->db->affected_rows() == 1;
}

Czy tak jest dobrze?